Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa5c867d authored Feb 03, 2016 by Suresh Reddy Committed by David S. Miller Feb 07, 2016

be2net: check for INSUFFICIENT_PRIVILEGES error

The driver currently logs the message "VF is not privileged to issue
opcode" by checking only the base_status field for UNAUTHORIZED_REQUEST.
Add check to look for INSUFFICIENT_PRIVILEGES in the additional status
field also as not all cmds fail with that base status.

Signed-off-by: Suresh Reddy <suresh.reddy@broadcom.com>
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a5a773a5

drivers/net/ethernet/emulex/benet/be_cmds.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -236,7 +236,8 @@ static int be_mcc_compl_process(struct be_adapter *adapter,

		if (base_status != MCC_STATUS_SUCCESS &&
		!be_skip_err_log(opcode, base_status, addl_status)) {
		if (base_status == MCC_STATUS_UNAUTHORIZED_REQUEST) {
		if (base_status == MCC_STATUS_UNAUTHORIZED_REQUEST \|\|
		addl_status == MCC_ADDL_STATUS_INSUFFICIENT_PRIVILEGES) {
		dev_warn(&adapter->pdev->dev,
		"VF is not privileged to issue opcode %d-%d\n",
		opcode, subsystem);

drivers/net/ethernet/emulex/benet/be_cmds.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -68,7 +68,8 @@ enum mcc_addl_status {
		MCC_ADDL_STATUS_TOO_MANY_INTERFACES = 0x4a,
		MCC_ADDL_STATUS_INSUFFICIENT_VLANS = 0xab,
		MCC_ADDL_STATUS_INVALID_SIGNATURE = 0x56,
		MCC_ADDL_STATUS_MISSING_SIGNATURE = 0x57
		MCC_ADDL_STATUS_MISSING_SIGNATURE = 0x57,
		MCC_ADDL_STATUS_INSUFFICIENT_PRIVILEGES = 0x60
		};

		#define CQE_BASE_STATUS_MASK 0xFFFF