Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa24b0cb authored by Jeremy Gebben's avatar Jeremy Gebben Committed by Patrick Daly
Browse files

iommu/arm-smmu: Tear down domain context if attach fails



Currently we're leaving domains half-initialized after a
partially-successful attach.  Fix this by destroying the domain in the
error path. This should allow another second attach_dev() call to
potentially succeed.

This differs from the upstream implementation in that upstream seems to
expect a call to domain_free() after a failed attach_dev(). Without
this call flow, an error in alloc_io_pgtable_ops() will cause a bit
from the context bank bitmask to be leaked.

Additionally, do not ignore errors from request_irq().

Change-Id: I36c529ed4974c01fba96088b6f57a8e82b350252
Signed-off-by: default avatarJeremy Gebben <jgebben@codeaurora.org>
Signed-off-by: default avatarPatrick Daly <pdaly@codeaurora.org>
parent cd9f07a9
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment