Commit f94b61c2 authored May 27, 2009 by Andi Kleen Committed by H. Peter Anvin Jun 03, 2009

x86, mce: implement panic synchronization



In some circumstances multiple CPUs can enter mce_panic() in parallel.
This gives quite confused output because they will all dump the same
machine check buffer.

The other problem is that they would all panic in parallel, but not
process each other's shutdown IPIs because interrupts are disabled.

Detect this situation early on in mce_panic(). On the first CPU
entering will do the panic, the others will just wait to be killed.

For paranoia reasons in case the other CPU dies during the MCE I added
a 5 seconds timeout. If it expires each CPU will panic on its own again.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>

parent ccc3c319

arch/x86/kernel/cpu/mcheck/mce.c

+22 −0

Original line number	Diff line number	Diff line
		@@ -196,10 +196,32 @@ static void print_mce(struct mce *m)
		"and contact your hardware vendor\n");
		}

		#define PANIC_TIMEOUT 5 /* 5 seconds */

		static atomic_t mce_paniced;

		/* Panic in progress. Enable interrupts and wait for final IPI */
		static void wait_for_panic(void)
		{
		long timeout = PANIC_TIMEOUT*USEC_PER_SEC;
		preempt_disable();
		local_irq_enable();
		while (timeout-- > 0)
		udelay(1);
		panic("Panicing machine check CPU died");
		}

		static void mce_panic(char msg, struct mce final, char *exp)
		{
		int i;

		/*
		* Make sure only one CPU runs in machine check panic
		*/
		if (atomic_add_return(1, &mce_paniced) > 1)
		wait_for_panic();
		barrier();

		bust_spinlocks(1);
		console_verbose();
		/* First print corrected ones that are still unlogged */