Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f945405c authored by Ben Dooks's avatar Ben Dooks Committed by Pierre Ossman
Browse files

sdhci: Add quirk for controllers with no end-of-busy IRQ 



The Samsung SDHCI (and FSL eSDHC) controller block seems to fail
to generate an INT_DATA_END after the transfer has completed and
the bus busy state finished.

Changes in e809517f to use the
new busy method are the cause of the behaviour change.

Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: default avatarPierre Ossman <drzeus@drzeus.cx>
parent 778ef1e6

drivers/mmc/host/sdhci.c

+4 −1
Original line number Diff line number Diff line
@@ -1291,8 +1291,11 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask) 
		if (host->cmd->data)

			DBG("Cannot wait for busy signal when also "

				"doing a data transfer");

		else

		else if (!(host->quirks & SDHCI_QUIRK_NO_BUSY_IRQ))

			return;



		/* The controller does not support the end-of-busy IRQ,

		 * fall through and take the SDHCI_INT_RESPONSE */

	}



	if (intmask & SDHCI_INT_RESPONSE)

drivers/mmc/host/sdhci.h

+2 −0
Original line number Diff line number Diff line
@@ -208,6 +208,8 @@ struct sdhci_host { 
#define SDHCI_QUIRK_BROKEN_TIMEOUT_VAL			(1<<12)

/* Controller has an issue with buffer bits for small transfers */

#define SDHCI_QUIRK_BROKEN_SMALL_PIO			(1<<13)

/* Controller does not provide transfer-complete interrupt when not busy */

#define SDHCI_QUIRK_NO_BUSY_IRQ				(1<<14)



	int			irq;		/* Device IRQ */

	void __iomem *		ioaddr;		/* Mapped address */