Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8646ad1 authored by Wen Yang's avatar Wen Yang Committed by Greg Kroah-Hartman
Browse files

ARM: exynos: Fix a leaked reference by adding missing of_node_put 



commit 629266bf7229cd6a550075f5961f95607b823b59 upstream.

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with warnings like:
    arch/arm/mach-exynos/firmware.c:201:2-8: ERROR: missing of_node_put;
        acquired a node pointer with refcount incremented on line 193,
        but without a corresponding object release within this function.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 15e6da9a

arch/arm/mach-exynos/firmware.c

+1 −0
Original line number Diff line number Diff line
@@ -205,6 +205,7 @@ void __init exynos_firmware_init(void) 
		return;



	addr = of_get_address(nd, 0, NULL, NULL);

	of_node_put(nd);

	if (!addr) {

		pr_err("%s: No address specified.\n", __func__);

		return;

arch/arm/mach-exynos/suspend.c

+2 −0
Original line number Diff line number Diff line
@@ -715,8 +715,10 @@ void __init exynos_pm_init(void) 


	if (WARN_ON(!of_find_property(np, "interrupt-controller", NULL))) {

		pr_warn("Outdated DT detected, suspend/resume will NOT work\n");

		of_node_put(np);

		return;

	}

	of_node_put(np);



	pm_data = (const struct exynos_pm_data *) match->data;