Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f72b751f authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

drm/atomic: fix an error code in mode_fixup() 



commit f9ad86e42d0303eeb8e0d41bb208153022ebd9d2 upstream.

Having "ret" be a bool type works for everything except
ret = funcs->atomic_check().  The other functions all return zero on
error but ->atomic_check() returns negative error codes.  We want to
propagate the error code but instead we return 1.

I found this bug with static analysis and I don't know if it affects
run time.

Fixes: 4cd4df80 ("drm/atomic: Add ->atomic_check() to encoder helpers")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170207234601.GA23981@mwanda


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 98620b56

drivers/gpu/drm/drm_atomic_helper.c

+1 −1
Original line number Diff line number Diff line
@@ -362,7 +362,7 @@ mode_fixup(struct drm_atomic_state *state) 
	struct drm_connector *connector;

	struct drm_connector_state *conn_state;

	int i;

	bool ret;

	int ret;



	for_each_crtc_in_state(state, crtc, crtc_state, i) {

		if (!crtc_state->mode_changed &&