Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f712c71f authored by Jean Delvare's avatar Jean Delvare Committed by Len Brown
Browse files

ACPI, APEI: Fixup common access width firmware bug 

Many firmwares have a common register definition bug where 8-bit
access width is specified for a 32-bit register. Ideally this should
be fixed in the BIOS, but earlier versions of the kernel did not
complain, so fix that up silently.

This closes kernel bug #43282:
https://bugzilla.kernel.org/show_bug.cgi?id=43282



Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Acked-by: default avatarHuang Ying <ying.huang@intel.com>
Acked-by: default avatarGary Hade <garyhade@us.ibm.com>
Cc: stable@vger.kernel.org [3.4+]
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 34ddeb03

drivers/acpi/apei/apei-base.c

+5 −0
Original line number Diff line number Diff line
@@ -586,6 +586,11 @@ static int apei_check_gar(struct acpi_generic_address *reg, u64 *paddr, 
	}

	*access_bit_width = 1UL << (access_size_code + 2);



	/* Fixup common BIOS bug */

	if (bit_width == 32 && bit_offset == 0 && (*paddr & 0x03) == 0 &&

	    *access_bit_width < 32)

		*access_bit_width = 32;



	if ((bit_width + bit_offset) > *access_bit_width) {

		pr_warning(FW_BUG APEI_PFX

			   "Invalid bit width + offset in GAR [0x%llx/%u/%u/%u/%u]\n",