Commit f6d2f6b3 authored May 22, 2011 by Eric Gouriou Committed by Theodore Ts'o May 22, 2011

ext4: fix unbalanced up_write() in ext4_ext_truncate() error path



ext4_ext_truncate() should not invoke up_write(&EXT4_I(inode)->i_data_sem)
when ext4_orphan_add() returns an error, as it hasn't performed a
down_write() yet. This trivial patch fixes this by moving the up_write()
invocation above the out_stop label.

Signed-off-by: Eric Gouriou <egouriou@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

parent 77f4135f

fs/ext4/extents.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3450,8 +3450,9 @@ void ext4_ext_truncate(struct inode *inode)
		if (IS_SYNC(inode))
		ext4_handle_sync(handle);

		out_stop:
		up_write(&EXT4_I(inode)->i_data_sem);

		out_stop:
		/*
		* If this was a simple ftruncate() and the file will remain alive,
		* then we need to clear up the orphan record which we created above.