Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6442aa0 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: tps65910: Remove unused min_uV and max_uV from struct tps_info 



The min_uV and max_uV fields of struct tps_info are not used in the code.
For the case voltage_table is provided, the min_uV and max_uV are the same
values as volt_table[0] and volt_table[n_voltages -1].
For the case voltage_table is not available, having the min_uV and max_uV seems
misleading. Current code uses equations to get the voltage value in this case,
but these equations do not use the min_uV and max_uV fields of struct tps_info.

Thus this patch removes the min_uV and max_uV fields from struct tps_info.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent b222a817

drivers/regulator/tps65910-regulator.c

+0 −50
Original line number Diff line number Diff line
@@ -85,8 +85,6 @@ static const u16 VMMC_VSEL_table[] = { 


struct tps_info {

	const char *name;

	unsigned min_uV;

	unsigned max_uV;

	u8 n_voltages;

	const u16 *voltage_table;

	int enable_time_us;
@@ -99,92 +97,68 @@ static struct tps_info tps65910_regs[] = { 
	},

	{

		.name = "vio",

		.min_uV = 1500000,

		.max_uV = 3300000,

		.n_voltages = ARRAY_SIZE(VIO_VSEL_table),

		.voltage_table = VIO_VSEL_table,

		.enable_time_us = 350,

	},

	{

		.name = "vdd1",

		.min_uV = 600000,

		.max_uV = 4500000,

		.enable_time_us = 350,

	},

	{

		.name = "vdd2",

		.min_uV = 600000,

		.max_uV = 4500000,

		.enable_time_us = 350,

	},

	{

		.name = "vdd3",

		.min_uV = 5000000,

		.max_uV = 5000000,

		.n_voltages = ARRAY_SIZE(VDD3_VSEL_table),

		.voltage_table = VDD3_VSEL_table,

		.enable_time_us = 200,

	},

	{

		.name = "vdig1",

		.min_uV = 1200000,

		.max_uV = 2700000,

		.n_voltages = ARRAY_SIZE(VDIG1_VSEL_table),

		.voltage_table = VDIG1_VSEL_table,

		.enable_time_us = 100,

	},

	{

		.name = "vdig2",

		.min_uV = 1000000,

		.max_uV = 1800000,

		.n_voltages = ARRAY_SIZE(VDIG2_VSEL_table),

		.voltage_table = VDIG2_VSEL_table,

		.enable_time_us = 100,

	},

	{

		.name = "vpll",

		.min_uV = 1000000,

		.max_uV = 2500000,

		.n_voltages = ARRAY_SIZE(VPLL_VSEL_table),

		.voltage_table = VPLL_VSEL_table,

		.enable_time_us = 100,

	},

	{

		.name = "vdac",

		.min_uV = 1800000,

		.max_uV = 2850000,

		.n_voltages = ARRAY_SIZE(VDAC_VSEL_table),

		.voltage_table = VDAC_VSEL_table,

		.enable_time_us = 100,

	},

	{

		.name = "vaux1",

		.min_uV = 1800000,

		.max_uV = 2850000,

		.n_voltages = ARRAY_SIZE(VAUX1_VSEL_table),

		.voltage_table = VAUX1_VSEL_table,

		.enable_time_us = 100,

	},

	{

		.name = "vaux2",

		.min_uV = 1800000,

		.max_uV = 3300000,

		.n_voltages = ARRAY_SIZE(VAUX2_VSEL_table),

		.voltage_table = VAUX2_VSEL_table,

		.enable_time_us = 100,

	},

	{

		.name = "vaux33",

		.min_uV = 1800000,

		.max_uV = 3300000,

		.n_voltages = ARRAY_SIZE(VAUX33_VSEL_table),

		.voltage_table = VAUX33_VSEL_table,

		.enable_time_us = 100,

	},

	{

		.name = "vmmc",

		.min_uV = 1800000,

		.max_uV = 3300000,

		.n_voltages = ARRAY_SIZE(VMMC_VSEL_table),

		.voltage_table = VMMC_VSEL_table,

		.enable_time_us = 100,
@@ -198,86 +172,62 @@ static struct tps_info tps65911_regs[] = { 
	},

	{

		.name = "vio",

		.min_uV = 1500000,

		.max_uV = 3300000,

		.n_voltages = ARRAY_SIZE(VIO_VSEL_table),

		.voltage_table = VIO_VSEL_table,

		.enable_time_us = 350,

	},

	{

		.name = "vdd1",

		.min_uV = 600000,

		.max_uV = 4500000,

		.n_voltages = 73,

		.enable_time_us = 350,

	},

	{

		.name = "vdd2",

		.min_uV = 600000,

		.max_uV = 4500000,

		.n_voltages = 73,

		.enable_time_us = 350,

	},

	{

		.name = "vddctrl",

		.min_uV = 600000,

		.max_uV = 1400000,

		.n_voltages = 65,

		.enable_time_us = 900,

	},

	{

		.name = "ldo1",

		.min_uV = 1000000,

		.max_uV = 3300000,

		.n_voltages = 47,

		.enable_time_us = 420,

	},

	{

		.name = "ldo2",

		.min_uV = 1000000,

		.max_uV = 3300000,

		.n_voltages = 47,

		.enable_time_us = 420,

	},

	{

		.name = "ldo3",

		.min_uV = 1000000,

		.max_uV = 3300000,

		.n_voltages = 24,

		.enable_time_us = 230,

	},

	{

		.name = "ldo4",

		.min_uV = 1000000,

		.max_uV = 3300000,

		.n_voltages = 47,

		.enable_time_us = 230,

	},

	{

		.name = "ldo5",

		.min_uV = 1000000,

		.max_uV = 3300000,

		.n_voltages = 24,

		.enable_time_us = 230,

	},

	{

		.name = "ldo6",

		.min_uV = 1000000,

		.max_uV = 3300000,

		.n_voltages = 24,

		.enable_time_us = 230,

	},

	{

		.name = "ldo7",

		.min_uV = 1000000,

		.max_uV = 3300000,

		.n_voltages = 24,

		.enable_time_us = 230,

	},

	{

		.name = "ldo8",

		.min_uV = 1000000,

		.max_uV = 3300000,

		.n_voltages = 24,

		.enable_time_us = 230,

	},