Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f63ef690 authored by Jan Kiszka's avatar Jan Kiszka Committed by Joerg Roedel
Browse files

iommu/vt-d: Don't store SIRTP request 



Don't store the SIRTP request bit in the register state. It will
otherwise become sticky and could request an Interrupt Remap Table
Pointer update on each command register write.

Found while starting to emulate IR in QEMU, not by observing problems on
real hardware.

Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 7d1311b9

drivers/iommu/intel_irq_remapping.c

+1 −2
Original line number Diff line number Diff line
@@ -438,8 +438,7 @@ static void iommu_set_irq_remapping(struct intel_iommu *iommu, int mode) 
		    (addr) | IR_X2APIC_MODE(mode) | INTR_REMAP_TABLE_REG_SIZE);



	/* Set interrupt-remapping table pointer */

	iommu->gcmd |= DMA_GCMD_SIRTP;

	writel(iommu->gcmd, iommu->reg + DMAR_GCMD_REG);

	writel(iommu->gcmd | DMA_GCMD_SIRTP, iommu->reg + DMAR_GCMD_REG);



	IOMMU_WAIT_OP(iommu, DMAR_GSTS_REG,

		      readl, (sts & DMA_GSTS_IRTPS), sts);