Commit f62c6d0a authored Sep 06, 2005 by Neil Horman Committed by Linus Torvalds Sep 07, 2005

[PATCH] Add missing overflow check in get_blkdev_list



Patch to clean up missing overflow check in get_blkdev_list.  The printf
which adds the "Block Devices" string in /proc/devices can overflow the
presented page if get_chrdev_list eats up the entire 4k space.

Signed-off-by: Neil Horman <nhorman@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent f23ef184

drivers/block/genhd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -45,7 +45,7 @@ int get_blkdev_list(char *p, int used)
		struct blk_major_name *n;
		int i, len;

		len = sprintf(p, "\nBlock devices:\n");
		len = snprintf(p, (PAGE_SIZE-used), "\nBlock devices:\n");

		down(&block_subsys_sem);
		for (i = 0; i < ARRAY_SIZE(major_names); i++) {