Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5d09f30 authored by Vara Reddy's avatar Vara Reddy
Browse files

drm/msm/dsi-staging: remove unnecesary locks from commit path 



Frame drops are observed when crtc_commit thread tries to hold panel
lock for updating the frame, while backlight service thread is
pushing the backlight commands holding panel_lock. Remove holding
panel lock from commit thread.

CRs-Fixed: 2179313
Change-Id: I7d6e5044db570102b7c2c7edb1c5c4b24847ed3f
Signed-off-by: default avatarVara Reddy <varar@codeaurora.org>
parent 6293e143

drivers/gpu/drm/msm/dsi-staging/dsi_ctrl.c

+1 −4
Original line number Diff line number Diff line 
/*

 * Copyright (c) 2016-2017, The Linux Foundation. All rights reserved.

 * Copyright (c) 2016-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -2673,9 +2673,6 @@ int dsi_ctrl_validate_timing(struct dsi_ctrl *dsi_ctrl, 
		return -EINVAL;

	}



	mutex_lock(&dsi_ctrl->ctrl_lock);

	mutex_unlock(&dsi_ctrl->ctrl_lock);



	return rc;

}

drivers/gpu/drm/msm/dsi-staging/dsi_panel.c

+1 −9
Original line number Diff line number Diff line 
/*

 * Copyright (c) 2016-2017, The Linux Foundation. All rights reserved.

 * Copyright (c) 2016-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -2960,11 +2960,7 @@ int dsi_panel_get_phy_props(struct dsi_panel *panel, 
		return -EINVAL;

	}



	mutex_lock(&panel->panel_lock);



	memcpy(phy_props, &panel->phy_props, sizeof(*phy_props));



	mutex_unlock(&panel->panel_lock);

	return rc;

}
@@ -2978,11 +2974,7 @@ int dsi_panel_get_dfps_caps(struct dsi_panel *panel, 
		return -EINVAL;

	}



	mutex_lock(&panel->panel_lock);



	memcpy(dfps_caps, &panel->dfps_caps, sizeof(*dfps_caps));



	mutex_unlock(&panel->panel_lock);

	return rc;

}