Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f51c23ba authored by Anderson Lizardo's avatar Anderson Lizardo Committed by David Vrabel
Browse files

wusb: fix error path for wusb_set_dev_addr() 



Error path for wusb_set_dev_addr() was handled incorrectly. Fix it by
considering error only when return value is negative.

Signed-off-by: default avatarAnderson Lizardo <anderson.lizardo@indt.org.br>
Signed-off-by: default avatarDavid Vrabel <david.vrabel@csr.com>
parent d09318b8

drivers/usb/wusbcore/devconnect.c

+3 −3
Original line number Diff line number Diff line
@@ -239,7 +239,7 @@ static struct wusb_dev *wusbhc_cack_add(struct wusbhc *wusbhc, 
			"port %u\n", dev_addr, port_idx);



		result = wusb_set_dev_addr(wusbhc, wusb_dev, dev_addr);

		if (result)

		if (result < 0)

			return NULL;

	}

	wusb_dev->entry_ts = jiffies;
@@ -1301,7 +1301,7 @@ int wusb_set_dev_addr(struct wusbhc *wusbhc, struct wusb_dev *wusb_dev, u8 addr) 


	wusb_dev->addr = addr;

	result = wusbhc->dev_info_set(wusbhc, wusb_dev);

	if (result)

	if (result < 0)

		dev_err(wusbhc->dev, "device %d: failed to set device "

			"address\n", wusb_dev->port_idx);

	else