Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f45f40ad authored by Lucas Tanure's avatar Lucas Tanure Committed by Greg Kroah-Hartman
Browse files

stm class: Use a signed return type for stm_find_master_chan 



The return type "unsigned int" was used by the stm_find_master_chan function
despite of the aspect that it will eventually return a negative error code.

Done with the help of Coccinelle.

Signed-off-by: default avatarLucas Tanure <tanure@linux.com>
Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 396ec3de

drivers/hwtracing/stm/core.c

+2 −2
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ static int find_free_channels(unsigned long *bitmap, unsigned int start, 
	return -1;

}



static unsigned int

static int

stm_find_master_chan(struct stm_device *stm, unsigned int width,

		     unsigned int *mstart, unsigned int mend,

		     unsigned int *cstart, unsigned int cend)
@@ -293,7 +293,7 @@ static int stm_output_assign(struct stm_device *stm, unsigned int width, 
		goto unlock;



	ret = stm_find_master_chan(stm, width, &midx, mend, &cidx, cend);

	if (ret)

	if (ret < 0)

		goto unlock;



	output->master = midx;