Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f415b429 authored by Tanya Dixit's avatar Tanya Dixit Committed by Gerrit - the friendly Code Review server
Browse files

dsp: add mutex unlock to properly release lock 



Add mutex unlock in function audio_effects_shared_ioctl
at appropriate place to prevent use after free.

CRs-Fixed: 2123291
Change-Id: Ie0d321dc8cc20a295d102a44faea7e5710834932
Signed-off-by: default avatarTanya Dixit <tdixit@codeaurora.org>
parent 7cb56be5

dsp/codecs/audio_hwacc_effects.c

+2 −3
Original line number Diff line number Diff line
@@ -161,7 +161,6 @@ static int audio_effects_shared_ioctl(struct file *file, unsigned int cmd, 
			pr_err("%s: Read buffer Allocation failed rc = %d\n",

				__func__, rc);

			rc = -ENOMEM;

			mutex_unlock(&effects->lock);

			goto readbuf_fail;

		}

		atomic_set(&effects->out_count, effects->config.output.num_buf);
@@ -176,7 +175,6 @@ static int audio_effects_shared_ioctl(struct file *file, unsigned int cmd, 
		if (rc < 0) {

			pr_err("%s: pcm read block config failed\n", __func__);

			rc = -EINVAL;

			mutex_unlock(&effects->lock);

			goto cfg_fail;

		}

		pr_debug("%s: dec: sample_rate: %d, num_channels: %d, bit_width: %d\n",
@@ -191,7 +189,6 @@ static int audio_effects_shared_ioctl(struct file *file, unsigned int cmd, 
			pr_err("%s: pcm write format block config failed\n",

				__func__);

			rc = -EINVAL;

			mutex_unlock(&effects->lock);

			goto cfg_fail;

		}
@@ -325,6 +322,7 @@ static int audio_effects_shared_ioctl(struct file *file, unsigned int cmd, 
readbuf_fail:

	q6asm_audio_client_buf_free_contiguous(IN,

					effects->ac);

	mutex_unlock(&effects->lock);

	return rc;

cfg_fail:

	q6asm_audio_client_buf_free_contiguous(IN,
@@ -332,6 +330,7 @@ static int audio_effects_shared_ioctl(struct file *file, unsigned int cmd, 
	q6asm_audio_client_buf_free_contiguous(OUT,

					effects->ac);

	effects->buf_alloc = 0;

	mutex_unlock(&effects->lock);

	return rc;

}