Commit f4156d1c authored Aug 11, 2008 by Carl Love Committed by Paul Mackerras Aug 26, 2008

powerpc/cell/oprofile: Avoid double vfree of profile buffer



If an error occurs on opcontrol start, the event and per cpu buffers
are released.  If later opcontrol shutdown is called then the free
function will be called again to free buffers that no longer
exist.  This results in a kernel oops.  The following changes
prevent the call to delete buffers that don't exist.

Signed-off-by: Carl Love <carll@us.ibm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Richter <robert.richter@amd.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent 2bb2e1db

drivers/oprofile/cpu_buffer.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -38,8 +38,10 @@ void free_cpu_buffers(void)
		{
		int i;

		for_each_online_cpu(i)
		for_each_online_cpu(i) {
		vfree(per_cpu(cpu_buffer, i).buffer);
		per_cpu(cpu_buffer, i).buffer = NULL;
		}
		}

		int alloc_cpu_buffers(void)

drivers/oprofile/event_buffer.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -93,6 +93,8 @@ int alloc_event_buffer(void)
		void free_event_buffer(void)
		{
		vfree(event_buffer);

		event_buffer = NULL;
		}