Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3db6639 authored by Michael Ellerman's avatar Michael Ellerman Committed by Linus Torvalds
Browse files

checkpatch: add a checkpatch warning for new uses of __initcall(). 



[apw@shadowen.org: generalise pattern and add tests]
Signed-off-by: default avatarMichael Ellerman <michael@ellerman.id.au>
Signed-off-by: default avatarAndy Whitcroft <apw@shadowen.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c8cb2ca3

scripts/checkpatch.pl

+4 −0
Original line number Diff line number Diff line
@@ -2108,6 +2108,10 @@ sub process { 
		if ($line =~ /\bsimple_(strto.*?)\s*\(/) {

			WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr);

		}

# check for __initcall(), use device_initcall() explicitly please

		if ($line =~ /^.\s*__initcall\s*\(/) {

			WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);

		}



# use of NR_CPUS is usually wrong

# ignore definitions of NR_CPUS and usage to define arrays as likely right