Commit f3c0ce86 authored Aug 28, 2016 by Markus Elfring Committed by Paul Mackerras Sep 12, 2016

KVM: PPC: e500: Use kmalloc_array() in kvm_vcpu_ioctl_config_tlb()



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>

parent 65e7026a

arch/powerpc/kvm/e500_mmu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -779,7 +779,7 @@ int kvm_vcpu_ioctl_config_tlb(struct kvm_vcpu *vcpu,

		num_pages = DIV_ROUND_UP(cfg->array + array_len - 1, PAGE_SIZE) -
		cfg->array / PAGE_SIZE;
		pages = kmalloc(sizeof(struct page ) num_pages, GFP_KERNEL);
		pages = kmalloc_array(num_pages, sizeof(*pages), GFP_KERNEL);
		if (!pages)
		return -ENOMEM;