Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f38cf9cc authored by K. Y. Srinivasan's avatar K. Y. Srinivasan Committed by Greg Kroah-Hartman
Browse files

Staging: hv: vmbus: Properly handle memory allocation failure in channel.c 



Properly handle memory allocation failure in channel.c.

Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarAbhishek Kane <v-abkane@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 40961de3

drivers/staging/hv/channel.c

+17 −2
Original line number Diff line number Diff line
@@ -355,9 +355,24 @@ static int create_gpadl_header(void *kbuffer, u32 size, 
				  sizeof(struct vmbus_channel_gpadl_body) +

				  pfncurr * sizeof(u64);

			msgbody = kzalloc(msgsize, GFP_KERNEL);

			/* FIXME: we probably need to more if this fails */

			if (!msgbody)



			if (!msgbody) {

				struct vmbus_channel_msginfo *pos = NULL;

				struct vmbus_channel_msginfo *tmp = NULL;

				/*

				 * Free up all the allocated messages.

				 */

				list_for_each_entry_safe(pos, tmp,

					&msgheader->submsglist,

					msglistentry) {



					list_del(&pos->msglistentry);

					kfree(pos);

				}



				goto nomem;

			}



			msgbody->msgsize = msgsize;

			(*messagecount)++;

			gpadl_body =