Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f37d49ad authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Felipe Balbi
Browse files

usb: gadget: r8a66597-udc: do not unlock unheld spinlock in r8a66597_sudmac_irq() 



r8a66597_irq() processes sudmac part (r8a66597_sudmac_irq()) before locking r8a66597->lock.
But transfer_complete(), that is called inside (r8a66597_sudmac_irq()->sudmac_finish()->transfer_complete()),
expects r8a66597->lock is locked. As a result unheld spinlock can be unlocked.

The patch just moves locking before calling r8a66597_sudmac_irq().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent a2cc81d3

drivers/usb/gadget/r8a66597-udc.c

+2 −2
Original line number Diff line number Diff line
@@ -1469,11 +1469,11 @@ static irqreturn_t r8a66597_irq(int irq, void *_r8a66597) 
	u16 savepipe;

	u16 mask0;



	spin_lock(&r8a66597->lock);



	if (r8a66597_is_sudmac(r8a66597))

		r8a66597_sudmac_irq(r8a66597);



	spin_lock(&r8a66597->lock);



	intsts0 = r8a66597_read(r8a66597, INTSTS0);

	intenb0 = r8a66597_read(r8a66597, INTENB0);