Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3766218 authored by Bjørn Mork's avatar Bjørn Mork Committed by Greg Kroah-Hartman
Browse files

net: cdc_ether: fix divide by 0 on bad descriptors 




[ Upstream commit 2cb80187ba065d7decad7c6614e35e07aec8a974 ]

Setting dev->hard_mtu to 0 will cause a divide error in
usbnet_probe. Protect against devices with bogus CDC Ethernet
functional descriptors by ignoring a zero wMaxSegmentSize.

Signed-off-by: default avatarBjørn Mork <bjorn@mork.no>
Acked-by: default avatarOliver Neukum <oneukum@suse.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6f239c06

drivers/net/usb/cdc_ether.c

+1 −1
Original line number Diff line number Diff line
@@ -221,7 +221,7 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf) 
			goto bad_desc;

	}



	if (header.usb_cdc_ether_desc) {

	if (header.usb_cdc_ether_desc && info->ether->wMaxSegmentSize) {

		dev->hard_mtu = le16_to_cpu(info->ether->wMaxSegmentSize);

		/* because of Zaurus, we may be ignoring the host

		 * side link address we were given.