Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1f45504 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Michal Marek
Browse files

scripts/coccinelle: Find threaded IRQs requests which are missing IRQF_ONESHOT 



Since commit 1c6c6952 ("genirq: Reject bogus threaded irq requests") threaded
IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise
the request will fail. This semantic patch will help to statically identify
(and fix) such cases.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
parent 5f011d71

scripts/coccinelle/misc/irqf_oneshot.cocci

0 → 100644
+65 −0
Original line number Diff line number Diff line 
/// Make sure threaded IRQs without a primary handler are always request with

/// IRQF_ONESHOT

///

//

// Confidence: Good

// Comments:

// Options: --no-includes



virtual patch

virtual context

virtual org

virtual report



@r1@

expression irq;

expression thread_fn;

expression flags;

position p;

@@

request_threaded_irq@p(irq, NULL, thread_fn,

(

flags | IRQF_ONESHOT

|

IRQF_ONESHOT

)

, ...)



@depends on patch@

expression irq;

expression thread_fn;

expression flags;

position p != r1.p;

@@

request_threaded_irq@p(irq, NULL, thread_fn,

(

-0

+IRQF_ONESHOT

|

-flags

+flags | IRQF_ONESHOT

)

, ...)



@depends on context@

position p != r1.p;

@@

*request_threaded_irq@p(...)



@match depends on report || org@

expression irq;

position p != r1.p;

@@

request_threaded_irq@p(irq, NULL, ...)



@script:python depends on org@

p << match.p;

@@

msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT"

coccilib.org.print_todo(p[0],msg)



@script:python depends on report@

p << match.p;

@@

msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT"

coccilib.report.print_report(p[0],msg)