Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f184cf52 authored by Steve Wise's avatar Steve Wise Committed by Greg Kroah-Hartman
Browse files

iw_cxgb4: remove the stid on listen create failure 



commit 8b1bbf36b7452c4acb20e91948eaa5e225ea6978 upstream.

If a listen create fails, then the server tid (stid) is incorrectly left
in the stid idr table, which can cause a touch-after-free if the stid
is looked up and the already freed endpoint is touched.  So make sure
and remove it in the error path.

Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eb4375e1

drivers/infiniband/hw/cxgb4/cm.c

+1 −1
Original line number Diff line number Diff line
@@ -3441,7 +3441,7 @@ int c4iw_create_listen(struct iw_cm_id *cm_id, int backlog) 
		cm_id->provider_data = ep;

		goto out;

	}



	remove_handle(ep->com.dev, &ep->com.dev->stid_idr, ep->stid);

	cxgb4_free_stid(ep->com.dev->rdev.lldi.tids, ep->stid,

			ep->com.local_addr.ss_family);

fail2: