Commit f16e9d86 authored Jun 01, 2015 by Vaishali Thakkar Committed by David S. Miller May 31, 2015

ethernet/intel: Use setup_timer



Use the timer API function setup_timer instead of structure field
assignments to initialize a timer.

A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:

@change@
expression e1, e2, e3, e4, a, b;
@@

-init_timer(&e1);
+setup_timer(&e1, a, b);

... when != a = e2
    when != b = e3

-e1.function = a;
... when != b = e4
-e1.data = b;

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3324b584

drivers/net/ethernet/intel/e100.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -2922,9 +2922,7 @@ static int e100_probe(struct pci_dev pdev, const struct pci_device_id ent)

		pci_set_master(pdev);

		init_timer(&nic->watchdog);
		nic->watchdog.function = e100_watchdog;
		nic->watchdog.data = (unsigned long)nic;
		setup_timer(&nic->watchdog, e100_watchdog, (unsigned long)nic);

		INIT_WORK(&nic->tx_timeout_task, e100_tx_timeout_task);