Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1453773 authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

target: Fix alua_access_state attribute OOPs for un-configured devices 



This patch fixes a OOPs where an attempt to write to the per-device
alua_access_state configfs attribute at:

  /sys/kernel/config/target/core/$HBA/$DEV/alua/$TG_PT_GP/alua_access_state

results in an NULL pointer dereference when the backend device has not
yet been configured.

This patch adds an explicit check for DF_CONFIGURED, and fails with
-ENODEV to avoid this case.

Reported-by: default avatarChris Boot <crb@tiger-computing.co.uk>
Reported-by: default avatarPhilip Gaw <pgaw@darktech.org.uk>
Cc: Chris Boot <crb@tiger-computing.co.uk>
Cc: Philip Gaw <pgaw@darktech.org.uk>
Cc: stable@vger.kernel.org # 3.8+
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent e7810c2d

drivers/target/target_core_configfs.c

+5 −0
Original line number Diff line number Diff line
@@ -2227,6 +2227,11 @@ static ssize_t target_core_alua_tg_pt_gp_store_attr_alua_access_state( 
			" tg_pt_gp ID: %hu\n", tg_pt_gp->tg_pt_gp_valid_id);

		return -EINVAL;

	}

	if (!(dev->dev_flags & DF_CONFIGURED)) {

		pr_err("Unable to set alua_access_state while device is"

		       " not configured\n");

		return -ENODEV;

	}



	ret = kstrtoul(page, 0, &tmp);

	if (ret < 0) {