Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f066055a authored by Dmitry Monakhov's avatar Dmitry Monakhov Committed by Theodore Ts'o
Browse files

ext4: online defrag is not supported for journaled files 



Proper block swap for inodes with full journaling enabled is
truly non obvious task. In order to be on a safe side let's
explicitly disable it for now.

Signed-off-by: default avatarDmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
parent 03bd8b9b

fs/ext4/move_extent.c

+6 −1
Original line number Diff line number Diff line
@@ -1142,7 +1142,12 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, 
			orig_inode->i_ino, donor_inode->i_ino);

		return -EINVAL;

	}



	/* TODO: This is non obvious task to swap blocks for inodes with full

	   jornaling enabled */

	if (ext4_should_journal_data(orig_inode) ||

	    ext4_should_journal_data(donor_inode)) {

		return -EINVAL;

	}

	/* Protect orig and donor inodes against a truncate */

	mext_inode_double_lock(orig_inode, donor_inode);