Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f03040eb authored by sayli karnik's avatar sayli karnik Committed by Greg Kroah-Hartman
Browse files

iio: bmi160_core: Fix sparse warning due to incorrect type in assignment 



commit dd4ba3fb22233e69f06399ee0aa7ecb11d2b595c upstream

There is a type mismatch between the buffer which is of type s16 and the
samples stored, which are declared as __le16.

Fix the following sparse warning:
drivers/iio/imu/bmi160/bmi160_core.c:411:26: warning: incorrect type
in assignment (different base types)

drivers/iio/imu/bmi160/bmi160_core.c:411:26: expected signed short
[signed] [short] [explicitly-signed] <noident>
drivers/iio/imu/bmi160/bmi160_core.c:411:26: got restricted __le16
[addressable] [usertype] sample

This is a cosmetic-type patch since it does not alter code behaviour.
The le16 is going into a 16bit buf element, and is labelled as IIO_LE in the
channel buffer definition.

Signed-off-by: default avatarsayli karnik <karniksayli1995@gmail.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
Signed-off-by: default avatarSudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2de7cf2c

drivers/iio/imu/bmi160/bmi160_core.c

+2 −1
Original line number Diff line number Diff line
@@ -385,7 +385,8 @@ static irqreturn_t bmi160_trigger_handler(int irq, void *p) 
	struct iio_poll_func *pf = p;

	struct iio_dev *indio_dev = pf->indio_dev;

	struct bmi160_data *data = iio_priv(indio_dev);

	s16 buf[16]; /* 3 sens x 3 axis x s16 + 3 x s16 pad + 4 x s16 tstamp */

	__le16 buf[16];

	/* 3 sens x 3 axis x __le16 + 3 x __le16 pad + 4 x __le16 tstamp */

	int i, ret, j = 0, base = BMI160_REG_DATA_MAGN_XOUT_L;

	__le16 sample;