Commit efe93a77 authored Mar 17, 2020 by Rikard Falkeborn Committed by Sasha Levin Jun 30, 2020

clk: sunxi: Fix incorrect usage of round_down()



[ Upstream commit ee25d9742dabed3fd18158b518f846abeb70f319 ]

round_down() can only round to powers of 2. If round_down() is asked
to round to something that is not a power of 2, incorrect results are
produced. The incorrect results can be both too large and too small.

Instead, use rounddown() which can round to any number.

Fixes: 6a721db1 ("clk: sunxi: Add A31 clocks support")
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a00ddd7b

drivers/clk/sunxi/clk-sunxi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -98,7 +98,7 @@ static void sun6i_a31_get_pll1_factors(struct factors_request *req)
		* Round down the frequency to the closest multiple of either
		* 6 or 16
		*/
		u32 round_freq_6 = round_down(freq_mhz, 6);
		u32 round_freq_6 = rounddown(freq_mhz, 6);
		u32 round_freq_16 = round_down(freq_mhz, 16);

		if (round_freq_6 > round_freq_16)