Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit efd5d9a4 authored by Carsten Otte's avatar Carsten Otte Committed by David S. Miller
Browse files

qeth: Fold qeth_misc debug area 



This patch removes the misc debug area. Instead of logging the entire skb
we just log a pointer to it into the card's local debug area in
qeth_core_get_next_skb. Other then that, this debug area is not used anywhere.

Signed-off-by: default avatarCarsten Otte <cotte@de.ibm.com>
Signed-off-by: default avatarFrank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d829eeef

drivers/s390/net/qeth_core.h

+0 −1
Original line number Diff line number Diff line
@@ -42,7 +42,6 @@ enum qeth_dbf_names { 
	QETH_DBF_SETUP,

	QETH_DBF_QERR,

	QETH_DBF_MSG,

	QETH_DBF_MISC,

	QETH_DBF_CTRL,

	QETH_DBF_INFOS	/* must be last element */

};

drivers/s390/net/qeth_core_main.c

+1 −3
Original line number Diff line number Diff line
@@ -36,8 +36,6 @@ struct qeth_dbf_info qeth_dbf[QETH_DBF_INFOS] = { 
				2, 1,   8, 2, &debug_hex_ascii_view, NULL},

	[QETH_DBF_MSG]   = {"qeth_msg",

				8, 1, 128, 3, &debug_sprintf_view,   NULL},

	[QETH_DBF_MISC]	 = {"qeth_misc",

				2, 1, 256, 2, &debug_hex_ascii_view, NULL},

	[QETH_DBF_CTRL]  = {"qeth_control",

		8, 1, QETH_DBF_CTRL_LEN, 5, &debug_hex_ascii_view, NULL},

};
@@ -4117,7 +4115,7 @@ struct sk_buff *qeth_core_get_next_skb(struct qeth_card *card, 
				QETH_DBF_TEXT(QERR, 2, "unexeob");

				QETH_DBF_TEXT_(QERR, 2, "%s",

					CARD_BUS_ID(card));

				QETH_DBF_HEX(MISC, 4, buffer, sizeof(*buffer));

				QETH_CARD_HEX(card, 2, buffer, sizeof(void *));

				dev_kfree_skb_any(skb);

				card->stats.rx_errors++;

				return NULL;