Commit efc47135 authored Feb 12, 2007 by Jiri Kosina Committed by Linus Torvalds Feb 12, 2007

[PATCH] DS1302: local_irq_disable() is redundant after local_irq_save()



drivers/char/ds1302.c::get_rtc_time() contains local_irq_disable() call
after local_irq_save(). This looks redundant.

drivers/char/ds1302.c::rtc_ioctl() contains local_irq_disable() call after
local_irq_save(). This looks redundant.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2869b23e

drivers/char/ds1302.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -120,7 +120,6 @@ get_rtc_time(struct rtc_time *rtc_tm)
		unsigned long flags;

		local_irq_save(flags);
		local_irq_disable();

		rtc_tm->tm_sec = CMOS_READ(RTC_SECONDS);
		rtc_tm->tm_min = CMOS_READ(RTC_MINUTES);
		@@ -219,7 +218,6 @@ rtc_ioctl(struct inode inode, struct file file, unsigned int cmd,
		BIN_TO_BCD(yrs);

		local_irq_save(flags);
		local_irq_disable();
		CMOS_WRITE(yrs, RTC_YEAR);
		CMOS_WRITE(mon, RTC_MONTH);
		CMOS_WRITE(day, RTC_DAY_OF_MONTH);