Commit ef8aef55 authored Sep 06, 2007 by Herbert Xu Committed by David S. Miller Sep 11, 2007

[NET]: Do not dereference iov if length is zero



When msg_iovlen is zero we shouldn't try to dereference
msg_iov.  Right now the only thing that tries to do so
is skb_copy_and_csum_datagram_iovec.  Since the total
length should also be zero if msg_iovlen is zero, it's
sufficient to check the total length there and simply
return if it's zero.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2fbe43f6

net/core/datagram.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -450,6 +450,9 @@ int skb_copy_and_csum_datagram_iovec(struct sk_buff *skb,
	__wsum csum;		__wsum csum;
	int chunk = skb->len - hlen;		int chunk = skb->len - hlen;

			if (!chunk)
			return 0;

	/* Skip filled elements.		/* Skip filled elements.
	* Pretty silly, look at memcpy_toiovec, though 8)		* Pretty silly, look at memcpy_toiovec, though 8)
	*/		*/