Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eecc5bbc authored by Joe Perches's avatar Joe Perches Committed by Matthew Garrett
Browse files

acerhdf: Message logging neatening 



Use pr_warn not pr_warning.
Coalesce formats.
Argument aligning.
Remove superfluous parentheses.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarLee, Chun-Yi <jlee@suse.com>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent 6e71f38b

drivers/platform/x86/acerhdf.c

+8 −11
Original line number Diff line number Diff line
@@ -244,8 +244,7 @@ static void acerhdf_change_fanstate(int state) 
	unsigned char cmd;



	if (verbose)

		pr_notice("fan %s\n", (state == ACERHDF_FAN_OFF) ?

				"OFF" : "ON");

		pr_notice("fan %s\n", state == ACERHDF_FAN_OFF ? "OFF" : "ON");



	if ((state != ACERHDF_FAN_OFF) && (state != ACERHDF_FAN_AUTO)) {

		pr_err("invalid fan state %d requested, setting to auto!\n",
@@ -275,8 +274,7 @@ static void acerhdf_check_param(struct thermal_zone_device *thermal) 
			interval = ACERHDF_MAX_INTERVAL;

		}

		if (verbose)

			pr_notice("interval changed to: %d\n",

					interval);

			pr_notice("interval changed to: %d\n", interval);

		thermal->polling_delay = interval*1000;

		prev_interval = interval;

	}
@@ -587,8 +585,8 @@ static int acerhdf_check_hardware(void) 
	}



	if (!bios_cfg) {

		pr_err("unknown (unsupported) BIOS version %s/%s/%s, "

			"please report, aborting!\n", vendor, product, version);

		pr_err("unknown (unsupported) BIOS version %s/%s/%s, please report, aborting!\n",

		       vendor, product, version);

		return -EINVAL;

	}
@@ -598,8 +596,7 @@ static int acerhdf_check_hardware(void) 
	 */

	if (!kernelmode) {

		pr_notice("Fan control off, to enable do:\n");

		pr_notice("echo -n \"enabled\" > "

			"/sys/class/thermal/thermal_zone0/mode\n");

		pr_notice("echo -n \"enabled\" > /sys/class/thermal/thermal_zone0/mode\n");

	}



	return 0;