Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee5182b5 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

mfd: sec: Remove sec_reg* regmap helpers 



Remove sec_reg* helpers as they are not used anymore. These helpers were
error-prone as they mixed u8 with unsigned int and they changed order of
some of parameters (val and mask in sec_reg_update()).

Also the helpers didn't give any way of useful abstraction as they just
called corresponding regmap function.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent d1c8b1bd

drivers/mfd/sec-core.c

+0 −30
Original line number Diff line number Diff line
@@ -79,36 +79,6 @@ static struct of_device_id sec_dt_match[] = { 
};

#endif



int sec_reg_read(struct sec_pmic_dev *sec_pmic, u8 reg, void *dest)

{

	return regmap_read(sec_pmic->regmap_pmic, reg, dest);

}

EXPORT_SYMBOL_GPL(sec_reg_read);



int sec_bulk_read(struct sec_pmic_dev *sec_pmic, u8 reg, int count, u8 *buf)

{

	return regmap_bulk_read(sec_pmic->regmap_pmic, reg, buf, count);

}

EXPORT_SYMBOL_GPL(sec_bulk_read);



int sec_reg_write(struct sec_pmic_dev *sec_pmic, u8 reg, u8 value)

{

	return regmap_write(sec_pmic->regmap_pmic, reg, value);

}

EXPORT_SYMBOL_GPL(sec_reg_write);



int sec_bulk_write(struct sec_pmic_dev *sec_pmic, u8 reg, int count, u8 *buf)

{

	return regmap_raw_write(sec_pmic->regmap_pmic, reg, buf, count);

}

EXPORT_SYMBOL_GPL(sec_bulk_write);



int sec_reg_update(struct sec_pmic_dev *sec_pmic, u8 reg, u8 val, u8 mask)

{

	return regmap_update_bits(sec_pmic->regmap_pmic, reg, mask, val);

}

EXPORT_SYMBOL_GPL(sec_reg_update);



static bool s2mps11_volatile(struct device *dev, unsigned int reg)

{

	switch (reg) {

include/linux/mfd/samsung/core.h

+0 −6
Original line number Diff line number Diff line
@@ -59,12 +59,6 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic); 
void sec_irq_exit(struct sec_pmic_dev *sec_pmic);

int sec_irq_resume(struct sec_pmic_dev *sec_pmic);



extern int sec_reg_read(struct sec_pmic_dev *sec_pmic, u8 reg, void *dest);

extern int sec_bulk_read(struct sec_pmic_dev *sec_pmic, u8 reg, int count, u8 *buf);

extern int sec_reg_write(struct sec_pmic_dev *sec_pmic, u8 reg, u8 value);

extern int sec_bulk_write(struct sec_pmic_dev *sec_pmic, u8 reg, int count, u8 *buf);

extern int sec_reg_update(struct sec_pmic_dev *sec_pmic, u8 reg, u8 val, u8 mask);



struct sec_platform_data {

	struct sec_regulator_data	*regulators;

	struct sec_opmode_data		*opmode;