Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee17b289 authored by Cyrill Gorcunov's avatar Cyrill Gorcunov Committed by Greg Kroah-Hartman
Browse files

USB Elan FTDI: check for workqueue creation 



Avoid NULL pointer usage if workqueue creation failed.

Signed-off-by: default avatarCyrill Gorcunov <gorcunov@gmail.com>
Cc: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 834dbca5

drivers/usb/misc/ftdi-elan.c

+16 −2
Original line number Diff line number Diff line
@@ -2909,13 +2909,27 @@ static int __init ftdi_elan_init(void) 
        init_MUTEX(&ftdi_module_lock);

        INIT_LIST_HEAD(&ftdi_static_list);

        status_queue = create_singlethread_workqueue("ftdi-status-control");

	if (!status_queue)

		goto err1;

        command_queue = create_singlethread_workqueue("ftdi-command-engine");

	if (!command_queue)

		goto err2;

        respond_queue = create_singlethread_workqueue("ftdi-respond-engine");

	if (!respond_queue)

		goto err3;

        result = usb_register(&ftdi_elan_driver);

        if (result)

                printk(KERN_ERR "usb_register failed. Error number %d\n",

		       result);

        return result;



 err3:

	destroy_workqueue(command_queue);

 err2:

	destroy_workqueue(status_queue);

 err1:

	printk(KERN_ERR "%s couldn't create workqueue\n", ftdi_elan_driver.name);

	return -ENOMEM;

}



static void __exit ftdi_elan_exit(void)