Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit edd28d31 authored by Patrick Bellasi's avatar Patrick Bellasi Committed by Dmitry Shmidt
Browse files

ANDROID: sched/{fair,tune}: track RUNNABLE tasks impact on per CPU boost value 



When per-task boosting is enabled, every time a task enters/exits a CPU
its boost value could impact the currently selected OPP for that CPU.
Thus, the "aggregated" boost value for that CPU potentially needs to
be updated to match the current maximum boost value among all the tasks
currently RUNNABLE on that CPU.

This patch introduces the required support to keep track of which boost
groups are impacting a CPU. Each time a task is enqueued/dequeued to/from
a CPU its boost group is used to increment a per-cpu counter of RUNNABLE
tasks on that CPU.
Only when the number of runnable tasks for a specific boost group
becomes 1 or 0 the corresponding boost group changes its effects on
that CPU, specifically:
  a) boost_group::tasks == 1: this boost group starts to impact the CPU
  b) boost_group::tasks == 0: this boost group stops to impact the CPU
In each of these two conditions the aggregation function:
  sched_cpu_update(cpu)
could be required to run in order to identify the new maximum boost
value required for the CPU.

The proposed patch minimizes the number of times the aggregation
function is executed while still providing the required support to
always boost a CPU to the maximum boost value required by all its
currently RUNNABLE tasks.

cc: Ingo Molnar <mingo@redhat.com>
cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: default avatarPatrick Bellasi <patrick.bellasi@arm.com>
Signed-off-by: default avatarAndres Oportus <andresoportus@google.com>
parent 9a871ed4

kernel/sched/fair.c

+13 −4
Original line number Diff line number Diff line
@@ -34,6 +34,7 @@ 
#include <trace/events/sched.h>



#include "sched.h"

#include "tune.h"



/*

 * Targeted preemption latency for CPU-bound tasks:
@@ -4604,6 +4605,8 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags) 
		    cpu_overutilized(rq->cpu))

			rq->rd->overutilized = true;



		schedtune_enqueue_task(p, cpu_of(rq));



		/*

		 * We want to potentially trigger a freq switch

		 * request only for tasks that are waking up; this is
@@ -4672,6 +4675,7 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags) 


	if (!se) {

		sub_nr_running(rq, 1);

		schedtune_dequeue_task(p, cpu_of(rq));



		/*

		 * We want to potentially trigger a freq switch
@@ -5572,10 +5576,15 @@ schedtune_margin(unsigned long signal, unsigned long boost) 
}



static inline unsigned int

schedtune_cpu_margin(unsigned long util)

schedtune_cpu_margin(unsigned long util, int cpu)

{

	unsigned int boost = get_sysctl_sched_cfs_boost();

	unsigned int boost;



#ifdef CONFIG_CGROUP_SCHEDTUNE

	boost = schedtune_cpu_boost(cpu);

#else

	boost = get_sysctl_sched_cfs_boost();

#endif

	if (boost == 0)

		return 0;
@@ -5585,7 +5594,7 @@ schedtune_cpu_margin(unsigned long util) 
#else /* CONFIG_SCHED_TUNE */



static inline unsigned int

schedtune_cpu_margin(unsigned long util)

schedtune_cpu_margin(unsigned long util, int cpu)

{

	return 0;

}
@@ -5596,7 +5605,7 @@ static inline unsigned long 
boosted_cpu_util(int cpu)

{

	unsigned long util = cpu_util(cpu);

	unsigned long margin = schedtune_cpu_margin(util);

	unsigned long margin = schedtune_cpu_margin(util, cpu);



	return util + margin;

}

kernel/sched/tune.c

+82 −0
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ 
#include <linux/err.h>

#include <linux/percpu.h>

#include <linux/printk.h>

#include <linux/rcupdate.h>

#include <linux/slab.h>



#include "sched.h"
@@ -158,6 +159,87 @@ schedtune_boostgroup_update(int idx, int boost) 
	return 0;

}



static inline void

schedtune_tasks_update(struct task_struct *p, int cpu, int idx, int task_count)

{

	struct boost_groups *bg;

	int tasks;



	bg = &per_cpu(cpu_boost_groups, cpu);



	/* Update boosted tasks count while avoiding to make it negative */

	if (task_count < 0 && bg->group[idx].tasks <= -task_count)

		bg->group[idx].tasks = 0;

	else

		bg->group[idx].tasks += task_count;



	/* Boost group activation or deactivation on that RQ */

	tasks = bg->group[idx].tasks;

	if (tasks == 1 || tasks == 0)

		schedtune_cpu_update(cpu);

}



/*

 * NOTE: This function must be called while holding the lock on the CPU RQ

 */

void schedtune_enqueue_task(struct task_struct *p, int cpu)

{

	struct schedtune *st;

	int idx;



	/*

	 * When a task is marked PF_EXITING by do_exit() it's going to be

	 * dequeued and enqueued multiple times in the exit path.

	 * Thus we avoid any further update, since we do not want to change

	 * CPU boosting while the task is exiting.

	 */

	if (p->flags & PF_EXITING)

		return;



	/* Get task boost group */

	rcu_read_lock();

	st = task_schedtune(p);

	idx = st->idx;

	rcu_read_unlock();



	schedtune_tasks_update(p, cpu, idx, 1);

}



/*

 * NOTE: This function must be called while holding the lock on the CPU RQ

 */

void schedtune_dequeue_task(struct task_struct *p, int cpu)

{

	struct schedtune *st;

	int idx;



	/*

	 * When a task is marked PF_EXITING by do_exit() it's going to be

	 * dequeued and enqueued multiple times in the exit path.

	 * Thus we avoid any further update, since we do not want to change

	 * CPU boosting while the task is exiting.

	 * The last dequeue will be done by cgroup exit() callback.

	 */

	if (p->flags & PF_EXITING)

		return;



	/* Get task boost group */

	rcu_read_lock();

	st = task_schedtune(p);

	idx = st->idx;

	rcu_read_unlock();



	schedtune_tasks_update(p, cpu, idx, -1);

}



int schedtune_cpu_boost(int cpu)

{

	struct boost_groups *bg;



	bg = &per_cpu(cpu_boost_groups, cpu);

	return bg->boost_max;

}



static u64

boost_read(struct cgroup_subsys_state *css, struct cftype *cft)

{

kernel/sched/tune.h

0 → 100644
+23 −0
Original line number Diff line number Diff line 


#ifdef CONFIG_SCHED_TUNE



#ifdef CONFIG_CGROUP_SCHEDTUNE



int schedtune_cpu_boost(int cpu);



void schedtune_enqueue_task(struct task_struct *p, int cpu);

void schedtune_dequeue_task(struct task_struct *p, int cpu);



#else /* CONFIG_CGROUP_SCHEDTUNE */



#define schedtune_enqueue_task(task, cpu) do { } while (0)

#define schedtune_dequeue_task(task, cpu) do { } while (0)



#endif /* CONFIG_CGROUP_SCHEDTUNE */



#else /* CONFIG_SCHED_TUNE */



#define schedtune_enqueue_task(task, cpu) do { } while (0)

#define schedtune_dequeue_task(task, cpu) do { } while (0)



#endif /* CONFIG_SCHED_TUNE */