Commit edb2c34f authored Mar 20, 2006 by David S. Miller

[NETFILTER]: Fix warnings in ip_nat_snmp_basic.c

net/ipv4/netfilter/ip_nat_snmp_basic.c: In function 'asn1_header_decode':
net/ipv4/netfilter/ip_nat_snmp_basic.c:248: warning: 'len' may be used uninitialized in this function
net/ipv4/netfilter/ip_nat_snmp_basic.c:248: warning: 'def' may be used uninitialized in this function
net/ipv4/netfilter/ip_nat_snmp_basic.c: In function 'snmp_translate':
net/ipv4/netfilter/ip_nat_snmp_basic.c:672: warning: 'l' may be used uninitialized in this function
net/ipv4/netfilter/ip_nat_snmp_basic.c:668: warning: 'type' may be used uninitialized in this function

Signed-off-by: David S. Miller <davem@davemloft.net>

parent fb950496

net/ipv4/netfilter/ip_nat_snmp_basic.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -250,6 +250,7 @@ static unsigned char asn1_header_decode(struct asn1_ctx *ctx,
		if (!asn1_id_decode(ctx, cls, con, tag))
		return 0;

		def = len = 0;
		if (!asn1_length_decode(ctx, &def, &len))
		return 0;

		@@ -699,11 +700,13 @@ static unsigned char snmp_object_decode(struct asn1_ctx *ctx,
		return 0;
		}

		type = 0;
		if (!snmp_tag_cls2syntax(tag, cls, &type)) {
		kfree(id);
		return 0;
		}

		l = 0;
		switch (type) {
		case SNMP_INTEGER:
		len = sizeof(long);