Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec3833ed authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: Force boolean subscript for expedited stall warnings 



The cpu_online() function can return values other than 0 and 1, which
can result in subscript overflow when applied to a two-element array.
This commit allows for this behavior by using "!!" on the return value
from cpu_online() when used as a subscript.

Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent e2fd9d35

kernel/rcu/tree.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -3808,7 +3808,7 @@ static void synchronize_sched_expedited_wait(struct rcu_state *rsp) 
				ndetected++;

				ndetected++;

				rdp = per_cpu_ptr(rsp->rda, cpu);

				rdp = per_cpu_ptr(rsp->rda, cpu);

				pr_cont(" %d-%c%c%c", cpu,

				pr_cont(" %d-%c%c%c", cpu,

					"O."[cpu_online(cpu)],

					"O."[!!cpu_online(cpu)],

					"o."[!!(rdp->grpmask & rnp->expmaskinit)],

					"o."[!!(rdp->grpmask & rnp->expmaskinit)],

					"N."[!!(rdp->grpmask & rnp->expmaskinitnext)]);

					"N."[!!(rdp->grpmask & rnp->expmaskinitnext)]);

			}

			}