Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec03ff1a authored by Christophe Ricard's avatar Christophe Ricard Committed by Samuel Ortiz
Browse files

NFC: st21nfca: Remove skb_pipe_list and skb_pipe_info useless allocation 



skb_pipe_list and skb_pipe_info are allocated in nfc_hci_send_cmd.
alloc_skb on those buffer are then useless.

Signed-off-by: default avatarChristophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 511e78a3

drivers/nfc/st21nfca/st21nfca.c

+0 −13
Original line number Diff line number Diff line
@@ -118,18 +118,6 @@ static int st21nfca_hci_load_session(struct nfc_hci_dev *hdev) 
		NFC_HCI_TERMINAL_HOST_ID, 0

	};



	skb_pipe_list = alloc_skb(ST21NFCA_HCI_LLC_MAX_SIZE, GFP_KERNEL);

	if (!skb_pipe_list) {

		r = -ENOMEM;

		goto free_list;

	}



	skb_pipe_info = alloc_skb(ST21NFCA_HCI_LLC_MAX_SIZE, GFP_KERNEL);

	if (!skb_pipe_info) {

		r = -ENOMEM;

		goto free_info;

	}



	/* On ST21NFCA device pipes number are dynamics

	 * A maximum of 16 pipes can be created at the same time

	 * If pipes are already created, hci_dev_up will fail.
@@ -212,7 +200,6 @@ static int st21nfca_hci_load_session(struct nfc_hci_dev *hdev) 
	memcpy(hdev->init_data.gates, st21nfca_gates, sizeof(st21nfca_gates));

free_info:

	kfree_skb(skb_pipe_info);

free_list:

	kfree_skb(skb_pipe_list);

	return r;

}