Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebd8e354 authored by Vijayavardhan Vennapusa's avatar Vijayavardhan Vennapusa Committed by Pratham Pratap
Browse files

USB: f_audio_source: Remove pm_qos request under non atomic context 



Currently driver is removing pm_qos request after acquiring spinlock in
pcm_close() callback. This could cause warning as pm_qos_remove_request()
can sleep. Hence move removing pm_qos request before acquiring spin lock.

Change-Id: I8e898934c4e83b80c994b2a293abbd920589ac62
Signed-off-by: default avatarVijayavardhan Vennapusa <vvreddy@codeaurora.org>
parent 739b514f

drivers/usb/gadget/function/f_audio_source.c

+2 −2
Original line number Diff line number Diff line
@@ -755,11 +755,11 @@ static int audio_pcm_close(struct snd_pcm_substream *substream) 
	struct audio_dev *audio = substream->private_data;

	unsigned long flags;



	spin_lock_irqsave(&audio->lock, flags);



	/* Remove the QoS request */

	pm_qos_remove_request(&audio->pm_qos);



	spin_lock_irqsave(&audio->lock, flags);



	audio->substream = NULL;

	spin_unlock_irqrestore(&audio->lock, flags);