Commit eb991089 authored Oct 23, 2008 by Jiri Slaby Committed by Jiri Kosina Oct 23, 2008

HID: fix lock imbalance in hiddev



Don't forget to unlock_kernel() in hiddev_ioctl_usage().
Added in 7961df16
(HID: Switch hiddev to unlocked_ioctl).

Corresponing sparse warning:
drivers/hid/usbhid/hiddev.c:515:10: warning: context imbalance in 'hiddev_ioctl_usage': wrong count at exit
drivers/hid/usbhid/hiddev.c:515:10:    context 'kernel_lock': wanted 0, got 1

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 0f2c5945

drivers/hid/usbhid/hiddev.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -436,8 +436,7 @@ static noinline int hiddev_ioctl_usage(struct hiddev *hiddev, unsigned int cmd,
		if (copy_to_user(user_arg, uref, sizeof(*uref)))
		goto fault;

		kfree(uref_multi);
		return 0;
		goto goodreturn;

		default:
		if (cmd != HIDIOCGUSAGE &&