Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb80ce74 authored by Yaniv Rosner's avatar Yaniv Rosner Committed by David S. Miller
Browse files

bnx2x: Fix potential link issue In BCM8727 based boards 



In BCM8727 based boards, setting default 10G link speed after link was
set to 1G may lead to link down issue. The problem was setting the right
value, but to the wrong registers

Signed-off-by: default avatarYaniv Rosner <yanivr@broadcom.com>
Signed-off-by: default avatarEilon Greenstein <eilong@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8ca60a68

drivers/net/bnx2x/bnx2x_link.c

+13 −10
Original line number Diff line number Diff line
@@ -4239,8 +4239,10 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars) 
			} else if ((params->req_line_speed ==

				    SPEED_AUTO_NEG) &&

				   ((params->speed_cap_mask &

				     PORT_HW_CFG_SPEED_CAPABILITY_D0_1G))) {



				     PORT_HW_CFG_SPEED_CAPABILITY_D0_1G)) &&

				   ((params->speed_cap_mask &

				     PORT_HW_CFG_SPEED_CAPABILITY_D0_10G) !=

				    PORT_HW_CFG_SPEED_CAPABILITY_D0_10G)) {

				DP(NETIF_MSG_LINK, "Setting 1G clause37\n");

				bnx2x_cl45_write(bp, params->port, ext_phy_type,

					       ext_phy_addr, MDIO_AN_DEVAD,
@@ -4254,10 +4256,11 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars) 
				default */

				bnx2x_cl45_write(bp, params->port, ext_phy_type,

					      ext_phy_addr, MDIO_AN_DEVAD,

					       MDIO_AN_REG_CTRL, 0x0020);

					      MDIO_AN_REG_8727_MISC_CTRL,

					      0x0020);

				bnx2x_cl45_write(bp, params->port, ext_phy_type,

					      ext_phy_addr, MDIO_AN_DEVAD,

					       0x7, 0x0100);

					      MDIO_AN_REG_CL37_AN, 0x0100);

				bnx2x_cl45_write(bp, params->port, ext_phy_type,

					      ext_phy_addr, MDIO_PMA_DEVAD,

					      MDIO_PMA_REG_CTRL, 0x2040);

drivers/net/bnx2x/bnx2x_reg.h

+2 −0
Original line number Diff line number Diff line
@@ -5211,6 +5211,8 @@ Theotherbitsarereservedandshouldbezero*/ 


#define MDIO_AN_REG_8073_2_5G		0x8329



#define MDIO_AN_REG_8727_MISC_CTRL	0x8309



#define MDIO_AN_REG_8481_LEGACY_MII_CTRL	0xffe0

#define MDIO_AN_REG_8481_LEGACY_AN_ADV		0xffe4

#define MDIO_AN_REG_8481_1000T_CTRL		0xffe9