Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb262a54 authored by Jingoo Han's avatar Jingoo Han Committed by Vinod Koul
Browse files

dma: sh: remove unnecessary platform_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Acked-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Acked-by: default avatarGuennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 1e69653d

drivers/dma/sh/shdmac.c

+0 −3
Original line number Diff line number Diff line
@@ -890,7 +890,6 @@ static int sh_dmae_probe(struct platform_device *pdev) 
	pm_runtime_put(&pdev->dev);

	pm_runtime_disable(&pdev->dev);



	platform_set_drvdata(pdev, NULL);

	shdma_cleanup(&shdev->shdma_dev);

eshdma:

	synchronize_rcu();
@@ -919,8 +918,6 @@ static int sh_dmae_remove(struct platform_device *pdev) 
	sh_dmae_chan_remove(shdev);

	shdma_cleanup(&shdev->shdma_dev);



	platform_set_drvdata(pdev, NULL);



	synchronize_rcu();



	return 0;

drivers/dma/sh/sudmac.c

+0 −2
Original line number Diff line number Diff line
@@ -391,7 +391,6 @@ static int sudmac_probe(struct platform_device *pdev) 
chan_probe_err:

	sudmac_chan_remove(su_dev);



	platform_set_drvdata(pdev, NULL);

	shdma_cleanup(&su_dev->shdma_dev);



	return err;
@@ -405,7 +404,6 @@ static int sudmac_remove(struct platform_device *pdev) 
	dma_async_device_unregister(dma_dev);

	sudmac_chan_remove(su_dev);

	shdma_cleanup(&su_dev->shdma_dev);

	platform_set_drvdata(pdev, NULL);



	return 0;

}