Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea38a6e0 authored by Dhoat Harpal's avatar Dhoat Harpal Committed by Gerrit - the friendly Code Review server
Browse files

soc: qcom: smem: Fix possible use of uninitialized variable 



Usage of uninitialized variable remote_host happens if common partition
header hosts value dont match with TOC values.

Add common partition check and error log if hosts mismatch with TOC.

CRs-Fixed: 1113351
Change-Id: I15f8823751abccf87c55e570a8a762bfb2cfb2df
Signed-off-by: default avatarDhoat Harpal <hdhoat@codeaurora.org>
Signed-off-by: default avatarArun Kumar Neelakantam <aneela@codeaurora.org>
parent 5eb04bd8

drivers/soc/qcom/msm_smem.c

+12 −6
Original line number Diff line number Diff line
@@ -1222,12 +1222,18 @@ static void smem_init_security_partition(struct smem_toc_entry *entry, 
		LOG_ERR("Smem partition %d cached heap exceeds size\n", num);

		BUG();

	}

	if (hdr->host0 == SMEM_COMM_HOST && hdr->host1 == SMEM_COMM_HOST) {

	if (is_comm_partition) {

		if (hdr->host0 == SMEM_COMM_HOST

			&& hdr->host1 == SMEM_COMM_HOST) {

			comm_partition.partition_num = num;

			comm_partition.offset = entry->offset;

			comm_partition.size_cacheline = entry->size_cacheline;

			SMEM_INFO("Common Partition %d offset:%x\n", num,

							entry->offset);

		} else {

			LOG_ERR("Smem Comm partition hosts don't match TOC\n");

			WARN_ON(1);

		}

		return;

	}

	if (hdr->host0 != SMEM_APPS && hdr->host1 != SMEM_APPS) {