Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea1409f9 authored by Sage Weil's avatar Sage Weil
Browse files

ceph: clear dir complete, invalidate dentry on replayed rename



If a rename operation is resent to the MDS following an MDS restart, the
client does not get a full reply (containing the resulting metadata) back.
In that case, a ceph_rename() needs to compensate by doing anything useful
that fill_inode() would have, like d_move().

It also needs to invalidate the dentry (to workaround the vfs_rename_dir()
bug) and clear the dir complete flag, just like fill_trace().

Signed-off-by: default avatarSage Weil <sage@newdream.net>
parent 5c6a2cdb
Loading
Loading
Loading
Loading
+9 −0
Original line number Diff line number Diff line
@@ -880,7 +880,16 @@ static int ceph_rename(struct inode *old_dir, struct dentry *old_dentry,
		 * do_request, above).  If there is no trace, we need
		 * to do it here.
		 */

		/* d_move screws up d_subdirs order */
		ceph_i_clear(new_dir, CEPH_I_COMPLETE);

		d_move(old_dentry, new_dentry);

		/* ensure target dentry is invalidated, despite
		   rehashing bug in vfs_rename_dir */
		new_dentry->d_time = jiffies;
		ceph_dentry(new_dentry)->lease_shared_gen = 0;
	}
	ceph_mdsc_put_request(req);
	return err;