Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e965be7d authored by Cyrille Pitchen's avatar Cyrille Pitchen Committed by David S. Miller
Browse files

net/macb: fix misplaced call of free_netdev() in macb_remove() 



fix a bug introduced by the multiqueue support patch:
"net/macb: add TX multiqueue support for gem"

the "bp" pointer to the netdev private data was dereferenced and used after the
associated memory had been freed by calling free_netdev().

Signed-off-by: default avatarCyrille Pitchen <cyrille.pitchen@atmel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6ff4a8ad

drivers/net/ethernet/cadence/macb.c

+1 −1
Original line number Diff line number Diff line
@@ -2408,11 +2408,11 @@ static int __exit macb_remove(struct platform_device *pdev) 
		queue = bp->queues;

		for (q = 0; q < bp->num_queues; ++q, ++queue)

			devm_free_irq(&pdev->dev, queue->irq, queue);

		free_netdev(dev);

		if (!IS_ERR(bp->tx_clk))

			clk_disable_unprepare(bp->tx_clk);

		clk_disable_unprepare(bp->hclk);

		clk_disable_unprepare(bp->pclk);

		free_netdev(dev);

	}



	return 0;