Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9414b6b authored by Abbas, Mohamed's avatar Abbas, Mohamed Committed by John W. Linville
Browse files

iwl3945: fix deep sleep when removing the driver. 

A warning message "MAC is in deep sleep" sometimes happen when user removes
the driver.  This warning is related to card not being ready. In __iwl3945_down
function some of the going down steps are in wrong order, to fix this this patch
do the following:
	1- make sure we are calling iwl3945_apm_reset and iwl3945_apm_stop
	   in the right order.

	2- make sure we set CSR_GP_CNTRL_REG_FLAG_INIT_DONE in apm_reset before
	   poll on CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY.

	3- set correct polling counter.

This fixes bug
http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=1834



Signed-off-by: default avatarmohamed abbas <mohamed.abbas@intel.com>
Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent c0af96a6

drivers/net/wireless/iwlwifi/iwl-3945.c

+3 −5
Original line number Diff line number Diff line
@@ -1338,6 +1338,9 @@ static int iwl3945_apm_reset(struct iwl_priv *priv) 
	spin_lock_irqsave(&priv->lock, flags);



	iwl_set_bit(priv, CSR_RESET, CSR_RESET_REG_FLAG_SW_RESET);

	udelay(10);



	iwl_set_bit(priv, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_INIT_DONE);



	iwl_poll_direct_bit(priv, CSR_GP_CNTRL,

			 CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY, 25000);
@@ -1347,11 +1350,6 @@ static int iwl3945_apm_reset(struct iwl_priv *priv) 
		iwl_write_prph(priv, APMG_CLK_CTRL_REG,

					 APMG_CLK_VAL_BSM_CLK_RQT);



		udelay(10);



		iwl_set_bit(priv, CSR_GP_CNTRL,

			    CSR_GP_CNTRL_REG_FLAG_INIT_DONE);



		iwl_write_prph(priv, APMG_RTC_INT_MSK_REG, 0x0);

		iwl_write_prph(priv, APMG_RTC_INT_STT_REG,

					0xFFFFFFFF);

drivers/net/wireless/iwlwifi/iwl-io.h

+1 −1
Original line number Diff line number Diff line
@@ -165,7 +165,7 @@ static inline int _iwl_grab_nic_access(struct iwl_priv *priv) 
	ret = _iwl_poll_bit(priv, CSR_GP_CNTRL,

			   CSR_GP_CNTRL_REG_VAL_MAC_ACCESS_EN,

			   (CSR_GP_CNTRL_REG_FLAG_MAC_CLOCK_READY |

			    CSR_GP_CNTRL_REG_FLAG_GOING_TO_SLEEP), 50);

			    CSR_GP_CNTRL_REG_FLAG_GOING_TO_SLEEP), 15000);

	if (ret < 0) {

		IWL_ERR(priv, "MAC is in deep sleep!\n");

		return -EIO;

drivers/net/wireless/iwlwifi/iwl3945-base.c

+6 −1
Original line number Diff line number Diff line
@@ -4941,6 +4941,7 @@ static void __iwl3945_down(struct iwl_priv *priv) 
			test_bit(STATUS_EXIT_PENDING, &priv->status) <<

				STATUS_EXIT_PENDING;



	priv->cfg->ops->lib->apm_ops.reset(priv);

	spin_lock_irqsave(&priv->lock, flags);

	iwl_clear_bit(priv, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);

	spin_unlock_irqrestore(&priv->lock, flags);
@@ -4958,7 +4959,11 @@ static void __iwl3945_down(struct iwl_priv *priv) 


	udelay(5);



	if (exit_pending || test_bit(STATUS_IN_SUSPEND, &priv->status))

		priv->cfg->ops->lib->apm_ops.stop(priv);

	else

		priv->cfg->ops->lib->apm_ops.reset(priv);



 exit:

	memset(&priv->card_alive, 0, sizeof(struct iwl_alive_resp));