Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e8b33150 authored by Zhang Qilong's avatar Zhang Qilong Committed by Greg Kroah-Hartman
Browse files

MIPS: Alchemy: Fix memleak in alchemy_clk_setup_cpu 



[ Upstream commit ac3b57adf87ad9bac7e33ca26bbbb13fae1ed62b ]

If the clk_register fails, we should free h before
function returns to prevent memleak.

Fixes: 47440229 ("MIPS: Alchemy: clock framework integration of onchip clocks")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d70dd845

arch/mips/alchemy/common/clock.c

+8 −1
Original line number Diff line number Diff line
@@ -151,6 +151,7 @@ static struct clk __init *alchemy_clk_setup_cpu(const char *parent_name, 
{

	struct clk_init_data id;

	struct clk_hw *h;

	struct clk *clk;



	h = kzalloc(sizeof(*h), GFP_KERNEL);

	if (!h)
@@ -163,7 +164,13 @@ static struct clk __init *alchemy_clk_setup_cpu(const char *parent_name, 
	id.ops = &alchemy_clkops_cpu;

	h->init = &id;



	return clk_register(NULL, h);

	clk = clk_register(NULL, h);

	if (IS_ERR(clk)) {

		pr_err("failed to register clock\n");

		kfree(h);

	}



	return clk;

}



/* AUXPLLs ************************************************************/