Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e899aa82 authored by Pavel Machek's avatar Pavel Machek Committed by Linus Torvalds
Browse files

strict_strto* is not strict enough 



It decodes "\n" as 0, which is bad, because stray echo into backlight
will turn your backlight off, etc...

Signed-off-by: default avatarPavel Machek <pavel@suse.cz>
Cc: Yi Yang <yi.y.yang@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ff083c83

lib/vsprintf.c

+4 −0
Original line number Diff line number Diff line
@@ -170,6 +170,8 @@ int strict_strtoul(const char *cp, unsigned int base, unsigned long *res) 
		return -EINVAL;



	val = simple_strtoul(cp, &tail, base);

	if (tail == cp)

		return -EINVAL;

	if ((*tail == '\0') ||

		((len == (size_t)(tail - cp) + 1) && (*tail == '\n'))) {

		*res = val;
@@ -241,6 +243,8 @@ int strict_strtoull(const char *cp, unsigned int base, unsigned long long *res) 
		return -EINVAL;



	val = simple_strtoull(cp, &tail, base);

	if (tail == cp)

		return -EINVAL;

	if ((*tail == '\0') ||

		((len == (size_t)(tail - cp) + 1) && (*tail == '\n'))) {

		*res = val;