Commit e86fb5e8 authored Dec 05, 2014 by Long Li Committed by Christoph Hellwig Dec 15, 2014

storvsc: ring buffer failures may result in I/O freeze



When ring buffer returns an error indicating retry, storvsc may not
return a proper error code to SCSI when bounce buffer is not used.
This has introduced I/O freeze on RAID running atop storvsc devices.
This patch fixes it by always returning a proper error code.

Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
cc: stable@vger.kernel.org

parent 60654e25

drivers/scsi/storvsc_drv.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -1688,14 +1688,13 @@ static int storvsc_queuecommand(struct Scsi_Host host, struct scsi_cmnd scmnd)
		if (ret == -EAGAIN) {
		/* no more space */

		if (cmd_request->bounce_sgl_count) {
		if (cmd_request->bounce_sgl_count)
		destroy_bounce_buffer(cmd_request->bounce_sgl,
		cmd_request->bounce_sgl_count);

		ret = SCSI_MLQUEUE_DEVICE_BUSY;
		goto queue_error;
		}
		}

		return 0;