Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e734a42f authored by Tobias Klauser's avatar Tobias Klauser Committed by David S. Miller
Browse files

net: ll_temac: Use of_property_read_u32 instead of open-coding it 



Use of_property_read_u32 to read the "clock-frequency" property instead
of using of_get_property with return value checks.

Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
Reviewed-by: default avatarSören Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 38cf595b

drivers/net/ethernet/xilinx/ll_temac_mdio.c

+4 −5
Original line number Diff line number Diff line
@@ -59,16 +59,15 @@ static int temac_mdio_write(struct mii_bus *bus, int phy_id, int reg, u16 val) 
int temac_mdio_setup(struct temac_local *lp, struct device_node *np)

{

	struct mii_bus *bus;

	const u32 *bus_hz;

	u32 bus_hz;

	int clk_div;

	int rc, size;

	int rc;

	struct resource res;



	/* Calculate a reasonable divisor for the clock rate */

	clk_div = 0x3f; /* worst-case default setting */

	bus_hz = of_get_property(np, "clock-frequency", &size);

	if (bus_hz && size >= sizeof(*bus_hz)) {

		clk_div = (*bus_hz) / (2500 * 1000 * 2) - 1;

	if (of_property_read_u32(np, "clock-frequency", &bus_hz) == 0) {

		clk_div = bus_hz / (2500 * 1000 * 2) - 1;

		if (clk_div < 1)

			clk_div = 1;

		if (clk_div > 0x3f)